Skip to content

A
Adyen Magento2

We will be off from 27/1 (Monday) to 31/1 (Friday) (GMT +7) for our Tet Holiday (Lunar New Year) in our country

Commit a10c5d32 authored by attilak's avatar attilak
Browse files
Options

Resolve code review comments

parent a9085ca5
Hide whitespace changes
Inline Side-by-side
Showing with 47 additions and 30 deletions
Gateway/Request/OneclickAuthorizationDataBuilder.php
View file @ a10c5d32
...@@ -92,9 +92,7 @@ class OneclickAuthorizationDataBuilder implements BuilderInterface ...@@ -92,9 +92,7 @@ class OneclickAuthorizationDataBuilder implements BuilderInterface
} }
// if installments is set add it into the request // if installments is set add it into the request
if ($payment->getAdditionalInformation(AdyenOneclickDataAssignObserver::NUMBER_OF_INSTALLMENTS) && if ($payment->getAdditionalInformation(AdyenOneclickDataAssignObserver::NUMBER_OF_INSTALLMENTS) > 0) {
$payment->getAdditionalInformation(AdyenOneclickDataAssignObserver::NUMBER_OF_INSTALLMENTS) > 0
) {
$request['installments']['value'] = $payment->getAdditionalInformation(AdyenOneclickDataAssignObserver::NUMBER_OF_INSTALLMENTS); $request['installments']['value'] = $payment->getAdditionalInformation(AdyenOneclickDataAssignObserver::NUMBER_OF_INSTALLMENTS);
} }
......
Helper/Data.php
View file @ a10c5d32
...@@ -177,7 +177,7 @@ class Data extends AbstractHelper ...@@ -177,7 +177,7 @@ class Data extends AbstractHelper
} }
/** /**
* @desc return recurring types for configuration setting * return recurring types for configuration setting
* @return array * @return array
*/ */
public function getRecurringTypes() public function getRecurringTypes()
...@@ -190,7 +190,7 @@ class Data extends AbstractHelper ...@@ -190,7 +190,7 @@ class Data extends AbstractHelper
} }
/** /**
* @desc return recurring types for configuration setting * return recurring types for configuration setting
* @return array * @return array
*/ */
public function getModes() public function getModes()
...@@ -202,7 +202,7 @@ class Data extends AbstractHelper ...@@ -202,7 +202,7 @@ class Data extends AbstractHelper
} }
/** /**
* @desc return recurring types for configuration setting * eturn recurring types for configuration setting
* @return array * @return array
*/ */
public function getCaptureModes() public function getCaptureModes()
...@@ -214,7 +214,7 @@ class Data extends AbstractHelper ...@@ -214,7 +214,7 @@ class Data extends AbstractHelper
} }
/** /**
* @desc return recurring types for configuration setting * return recurring types for configuration setting
* @return array * @return array
*/ */
public function getPaymentRoutines() public function getPaymentRoutines()
...@@ -373,7 +373,8 @@ class Data extends AbstractHelper ...@@ -373,7 +373,8 @@ class Data extends AbstractHelper
/** /**
* @desc gives back global configuration values * gives back global configuration values
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -384,7 +385,8 @@ class Data extends AbstractHelper ...@@ -384,7 +385,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc gives back global configuration values as boolean * gives back global configuration values as boolean
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -395,7 +397,8 @@ class Data extends AbstractHelper ...@@ -395,7 +397,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_cc configuration values * Gives back adyen_cc configuration values
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -406,7 +409,8 @@ class Data extends AbstractHelper ...@@ -406,7 +409,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_cc configuration values as flag * Gives back adyen_cc configuration values as flag
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -417,7 +421,8 @@ class Data extends AbstractHelper ...@@ -417,7 +421,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_cc configuration values as flag * Gives back adyen_cc configuration values as flag
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -428,7 +433,8 @@ class Data extends AbstractHelper ...@@ -428,7 +433,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_hpp configuration values * Gives back adyen_hpp configuration values
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -439,7 +445,8 @@ class Data extends AbstractHelper ...@@ -439,7 +445,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_hpp configuration values as flag * Gives back adyen_hpp configuration values as flag
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -450,7 +457,8 @@ class Data extends AbstractHelper ...@@ -450,7 +457,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_oneclick configuration values * Gives back adyen_oneclick configuration values
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -461,7 +469,8 @@ class Data extends AbstractHelper ...@@ -461,7 +469,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_oneclick configuration values as flag * Gives back adyen_oneclick configuration values as flag
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -492,7 +501,8 @@ class Data extends AbstractHelper ...@@ -492,7 +501,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_pay_by_mail configuration values * Gives back adyen_pay_by_mail configuration values
*
* @param $field * @param $field
* @param int|null $storeId * @param int|null $storeId
* @return mixed * @return mixed
...@@ -503,7 +513,8 @@ class Data extends AbstractHelper ...@@ -503,7 +513,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_pay_by_mail configuration values as flag * Gives back adyen_pay_by_mail configuration values as flag
*
* @param $field * @param $field
* @param int|null $storeId * @param int|null $storeId
* @return mixed * @return mixed
...@@ -514,7 +525,8 @@ class Data extends AbstractHelper ...@@ -514,7 +525,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_boleto configuration values * Gives back adyen_boleto configuration values
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -525,7 +537,8 @@ class Data extends AbstractHelper ...@@ -525,7 +537,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_boleto configuration values as flag * Gives back adyen_boleto configuration values as flag
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -536,7 +549,8 @@ class Data extends AbstractHelper ...@@ -536,7 +549,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Gives back adyen_apple_pay configuration values * Gives back adyen_apple_pay configuration values
*
* @param $field * @param $field
* @param null $storeId * @param null $storeId
* @return mixed * @return mixed
...@@ -575,7 +589,8 @@ class Data extends AbstractHelper ...@@ -575,7 +589,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Retrieve decrypted hmac key * Retrieve decrypted hmac key
*
* @return string * @return string
*/ */
public function getHmac() public function getHmac()
...@@ -605,7 +620,7 @@ class Data extends AbstractHelper ...@@ -605,7 +620,7 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Check if configuration is set to demo mode * Check if configuration is set to demo mode
* *
* @param int|null $storeId * @param int|null $storeId
* @return mixed * @return mixed
...@@ -616,7 +631,8 @@ class Data extends AbstractHelper ...@@ -616,7 +631,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Retrieve the decrypted notification password * Retrieve the decrypted notification password
*
* @return string * @return string
*/ */
public function getNotificationPassword() public function getNotificationPassword()
...@@ -625,7 +641,7 @@ class Data extends AbstractHelper ...@@ -625,7 +641,7 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Retrieve the API key * Retrieve the API key
* *
* @param int|null $storeId * @param int|null $storeId
* @return string * @return string
...@@ -643,7 +659,7 @@ class Data extends AbstractHelper ...@@ -643,7 +659,7 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Retrieve the webserver username * Retrieve the webserver username
* *
* @param int|null $storeId * @param int|null $storeId
* @return string * @return string
...@@ -659,7 +675,7 @@ class Data extends AbstractHelper ...@@ -659,7 +675,7 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Retrieve the Live endpoint prefix key * Retrieve the Live endpoint prefix key
* *
* @param int|null $storeId * @param int|null $storeId
* @return string * @return string
...@@ -671,7 +687,8 @@ class Data extends AbstractHelper ...@@ -671,7 +687,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Cancels the order * Cancels the order
*
* @param $order * @param $order
*/ */
public function cancelOrder($order) public function cancelOrder($order)
...@@ -733,7 +750,8 @@ class Data extends AbstractHelper ...@@ -733,7 +750,8 @@ class Data extends AbstractHelper
} }
/** /**
* @desc Retrieve information from payment configuration * Retrieve information from payment configuration
*
* @param $field * @param $field
* @param $paymentMethodCode * @param $paymentMethodCode
* @param $storeId * @param $storeId
...@@ -1575,7 +1593,8 @@ class Data extends AbstractHelper ...@@ -1575,7 +1593,8 @@ class Data extends AbstractHelper
/** /**
* @desc Check if CreditCard vault is enabled * Check if CreditCard vault is enabled
*
* @param int|null $storeId * @param int|null $storeId
* @return mixed * @return mixed
*/ */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment