Fix LGTM JS issues

view/frontend/web/js/model/adyen-payment-service.js

@@ -19,8 +19,6 @@ define(
              * Retrieve the list of available payment methods from the server
              */
             retrieveAvailablePaymentMethods: function () {
-                var self = this;
-
                 // retrieve payment methods
                 var serviceUrl,
                     payload;

view/frontend/web/js/view/payment/adyen-methods.js

@@ -68,15 +68,13 @@ define(
         /** Add view logic here if needed */
         return Component.extend({
             initialize: function () {
-                var self = this;
                 this._super();
 
                 adyenPaymentService.retrieveAvailablePaymentMethods().done(function (response) {
 
                     var responseJson = JSON.parse(response);
                     var paymentMethodsResponse = responseJson.paymentMethodsResponse;
-                    var paymentMethods = paymentMethodsResponse.paymentMethods;
-
+                    
                     // TODO check if this is still required or if can be outsourced for the generic component, or checkout can create a ratepay component
                     /*if (!!window.checkoutConfig.payment.adyenHpp) {
                         if (JSON.stringify(paymentMethods).indexOf("ratepay") > -1) {

view/frontend/web/js/view/payment/method-renderer/adyen-oneclick-method.js

@@ -73,7 +73,6 @@ define(
         var recurringDetailReference = ko.observable(null);
         var variant = ko.observable(null);
         var paymentMethod = ko.observable(null);
-        var numberOfInstallments = ko.observable(null);
         var isValid = ko.observable(false);
 
         return Component.extend({
@@ -81,7 +80,6 @@ define(
                 template: 'Adyen_Payment/payment/oneclick-form',
                 recurringDetailReference: '',
                 variant: '',
-                numberOfInstallments: '',
                 checkoutComponent: {},
                 storedPayments: []
             },
@@ -90,8 +88,7 @@ define(
                     .observe([
                         'recurringDetailReference',
                         'creditCardType',
-                        'variant',
-                        'numberOfInstallments'
+                        'variant'
                     ]);
                 return this;
             },
@@ -231,7 +228,7 @@ define(
                                 }
                             });
 
-                            var oneClickCard = self.checkoutComponent
+                            self.checkoutComponent
                                 .create(storedPayment.type, configuration)
                                 .mount('#storedPaymentContainer-' + self.value);
                         },