[PW-3127] Validate payment methods (#838)

* payment methods response validation

* Remove getConnectedTerminals

* Refactor

* Fix suggestions

* Refactor paymentmethods

* Refactor method names

* Refactor payment method request

Helper/ConnectedTerminals.php

+<?php
+/**
+ *                       ######
+ *                       ######
+ * ############    ####( ######  #####. ######  ############   ############
+ * #############  #####( ######  #####. ######  #############  #############
+ *        ######  #####( ######  #####. ######  #####  ######  #####  ######
+ * ###### ######  #####( ######  #####. ######  #####  #####   #####  ######
+ * ###### ######  #####( ######  #####. ######  #####          #####  ######
+ * #############  #############  #############  #############  #####  ######
+ *  ############   ############  #############   ############  #####  ######
+ *                                      ######
+ *                               #############
+ *                               ############
+ *
+ * Adyen Payment module (https://www.adyen.com/)
+ *
+ * Copyright (c) 2020 Adyen BV (https://www.adyen.com/)
+ * See LICENSE.txt for license details.
+ *
+ * Author: Adyen <magento@adyen.com>
+ */
+
+namespace Adyen\Payment\Helper;
+
+class ConnectedTerminals
+{
+    /**
+     * @var \Magento\Checkout\Model\Session
+     */
+    protected $session;
+
+    /**
+     * @var \Adyen\Payment\Helper\Data
+     */
+    protected $adyenHelper;
+
+    public function __construct(
+        \Adyen\Payment\Helper\Data $adyenHelper,
+        \Magento\Checkout\Model\Session $session
+    ) {
+        $this->adyenHelper = $adyenHelper;
+        $this->session = $session;
+    }
+
+    /**
+     * @return array|mixed
+     * @throws \Adyen\AdyenException
+     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     */
+    public function getConnectedTerminals()
+    {
+        $storeId = $this->session->getQuote()->getStoreId();
+
+        // initialize the adyen client
+        $client = $this->adyenHelper->initializeAdyenClient($storeId, $this->adyenHelper->getPosApiKey($storeId));
+
+        // initialize service
+        $service = $this->adyenHelper->createAdyenPosPaymentService($client);
+
+        $requestParams = [
+            "merchantAccount" => $this->adyenHelper->getAdyenMerchantAccount('adyen_pos_cloud', $storeId),
+        ];
+
+        // In case the POS store id is set, provide in the request
+        if (!empty($this->adyenHelper->getPosStoreId($storeId))) {
+            $requestParams['store'] = $this->adyenHelper->getPosStoreId($storeId);
+        }
+
+        try {
+            $responseData = $service->getConnectedTerminals($requestParams);
+        } catch (\Adyen\AdyenException $e) {
+            $this->adyenLogger->error(
+                "The getConnectedTerminals response is empty check your Adyen configuration in Magento."
+            );
+            // return empty result
+            return [];
+        }
+
+        return $responseData;
+    }
+}

Model/Ui/AdyenPosCloudConfigProvider.php

@@ -43,9 +43,9 @@ class AdyenPosCloudConfigProvider implements ConfigProviderInterface
     protected $urlBuilder;
 
     /**
-     * @var \Adyen\Payment\Helper\PaymentMethods
+     * @var \Adyen\Payment\Helper\ConnectedTerminals
      */
-    protected $paymentMethodsHelper;
+    protected $connectedTerminalsHelper;
 
     /**
      * @var \Adyen\Payment\Helper\Data
@@ -62,20 +62,20 @@ class AdyenPosCloudConfigProvider implements ConfigProviderInterface
      *
      * @param \Magento\Framework\App\RequestInterface $request
      * @param \Magento\Framework\UrlInterface $urlBuilder
-     * @param \Adyen\Payment\Helper\PaymentMethods $paymentMethodsHelper
+     * @param \Adyen\Payment\Helper\ConnectedTerminals $connectedTerminalsHelper
      * @param \Adyen\Payment\Helper\Data $adyenHelper
      * @param \Magento\Framework\Serialize\SerializerInterface $serializer
      */
     public function __construct(
         \Magento\Framework\App\RequestInterface $request,
         \Magento\Framework\UrlInterface $urlBuilder,
-        \Adyen\Payment\Helper\PaymentMethods $paymentMethodsHelper,
+        \Adyen\Payment\Helper\ConnectedTerminals $connectedTerminalsHelper,
         \Adyen\Payment\Helper\Data $adyenHelper,
         \Magento\Framework\Serialize\SerializerInterface $serializer
     ) {
         $this->request = $request;
         $this->urlBuilder = $urlBuilder;
-        $this->paymentMethodsHelper = $paymentMethodsHelper;
+        $this->connectedTerminalsHelper = $connectedTerminalsHelper;
         $this->adyenHelper = $adyenHelper;
         $this->serializer = $serializer;
     }
@@ -137,7 +137,7 @@ class AdyenPosCloudConfigProvider implements ConfigProviderInterface
      */
     protected function getConnectedTerminals()
     {
-        $connectedTerminals = $this->paymentMethodsHelper->getConnectedTerminals();
+        $connectedTerminals = $this->connectedTerminalsHelper->getConnectedTerminals();
 
         if (!empty($connectedTerminals['uniqueTerminalIds'])) {
             return $connectedTerminals['uniqueTerminalIds'];