[PW-2286]: Avoiding order cancellation in Result controller (#719)

* [PW-2286]: Avoiding order cancellation in Result controller

* Update Controller/Process/Result.php
Co-authored-by: Ángel Campos <angel.campos@adyen.com>

* [PW-2286]: Simplifying switch in Result.php

* Update Controller/Process/Result.php
Co-authored-by: Marcos Garcia <marcos.asgarcia@gmail.com>

* Update Controller/Process/Result.php
Co-authored-by: Attila Kiss <42297201+cyattilakiss@users.noreply.github.com>
Co-authored-by: Marcos Garcia <marcos.asgarcia@gmail.com>

Controller/Process/Result.php

@@ -107,7 +107,14 @@ class Result extends \Magento\Framework\App\Action\Action
                 $session->getQuote()->setIsActive(false)->save();
                 $this->_redirect('checkout/onepage/success', ['_query' => ['utm_nooverride' => '1']]);
             } else {
-                $this->_cancel($response);
+                $this->_adyenLogger->addAdyenResult(
+                    sprintf(
+                        'Payment for order %s was unsuccessful, ' .
+                        'it will be cancelled when the OFFER_CLOSED notification has been processed.',
+                        $this->_order->getIncrementId()
+                    )
+                );
+                $this->restoreCart($response);
                 $failReturnPath = $this->_adyenHelper->getAdyenAbstractConfigData('return_path');
                 $this->_redirect($failReturnPath);
             }
@@ -121,17 +128,13 @@ class Result extends \Magento\Framework\App\Action\Action
     /**
      * @param $response
      */
-    protected function _cancel($response)
+    protected function restoreCart($response)
     {
         $session = $this->_session;
 
         // restore the quote
         $session->restoreQuote();
 
-        $order = $this->_order;
-
-        $this->_adyenHelper->cancelOrder($order);
-
         if (isset($response['authResult']) && $response['authResult'] == \Adyen\Payment\Model\Notification::CANCELLED) {
             $this->messageManager->addError(__('You have cancelled the order. Please try again'));
         } else {
@@ -270,17 +273,13 @@ class Result extends \Magento\Framework\App\Action\Action
                 $this->_adyenLogger->addAdyenResult('Do nothing wait for the notification');
                 break;
             case Notification::CANCELLED:
-                $this->_adyenLogger->addAdyenResult('Cancel or Hold the order');
+            case Notification::ERROR:
+                $this->_adyenLogger->addAdyenResult('Cancel or Hold the order on OFFER_CLOSED notification');
                 $result = false;
                 break;
             case Notification::REFUSED:
                 // if refused there will be a AUTHORIZATION : FALSE notification send only exception is idea
-                $this->_adyenLogger->addAdyenResult('Cancel or Hold the order');
-                $result = false;
-                break;
-            case Notification::ERROR:
-                //attempt to hold/cancel
-                $this->_adyenLogger->addAdyenResult('Cancel or Hold the order');
+                $this->_adyenLogger->addAdyenResult('Cancel or Hold the order on AUTHORISATION success = false notification');
                 $result = false;
                 break;
             default: