[PW-2236] Remove idempotency from alternative payment methods (#721)

* Remove idempotency from alternative payment methods

* Fix sonar cloud code smell

Gateway/Http/Client/TransactionAuthorization.php

@@ -64,14 +64,8 @@ class TransactionAuthorization implements ClientInterface
     public function placeRequest(\Magento\Payment\Gateway\Http\TransferInterface $transferObject)
     {
         $request = $transferObject->getBody();
-        $headers = $transferObject->getHeaders();
-
         $requestOptions = [];
 
-        if (!empty($headers['idempotencyKey'])) {
-            $requestOptions['idempotencyKey'] = $headers['idempotencyKey'];
-        }
-
         // call lib
         $service = new \Adyen\Service\Payment($this->client);
 

Gateway/Http/Client/TransactionPayment.php

@@ -63,7 +63,6 @@ class TransactionPayment implements ClientInterface
     public function placeRequest(\Magento\Payment\Gateway\Http\TransferInterface $transferObject)
     {
         $request = $transferObject->getBody();
-        $headers = $transferObject->getHeaders();
 
         // If the payments call is already done return the request
         if (!empty($request['resultCode'])) {
@@ -77,10 +76,6 @@ class TransactionPayment implements ClientInterface
 
         $requestOptions = [];
 
-        if (!empty($headers['idempotencyKey'])) {
-            $requestOptions['idempotencyKey'] = $headers['idempotencyKey'];
-        }
-
         $request = $this->applicationInfo->addMerchantApplicationIntoRequest($request);
 
         try {

Gateway/Request/PaymentDataBuilder.php

@@ -63,9 +63,7 @@ class PaymentDataBuilder implements BuilderInterface
         $paymentMethod = $payment->getMethod();
 
         $request['body'] = $this->adyenRequestsHelper->buildPaymentData([], $amount, $currencyCode, $reference, $paymentMethod);
-
-        $request['headers'] = $this->adyenRequestsHelper->addIdempotencyKey([], $paymentMethod, $reference);
-
+        
         return $request;
     }
 }

Helper/Requests.php

@@ -492,21 +492,4 @@ class Requests extends AbstractHelper
 
         return $address;
     }
-
-    /**
-     * Only adds idempotency key if payment method is adyen_hpp for now
-     *
-     * @param array $request
-     * @param $paymentMethod
-     * @param $idempotencyKey
-     * @return array
-     */
-    public function addIdempotencyKey($request = [], $paymentMethod, $idempotencyKey)
-    {
-        if (!empty($paymentMethod) && $paymentMethod == 'adyen_hpp') {
-            $request['idempotencyKey'] = $idempotencyKey;
-        }
-
-        return $request;
-    }
 }