use Magento\Framework\Serialize\Serializer\Serialize, fix typo on...

use Magento\Framework\Serialize\Serializer\Serialize, fix typo on setAdditionalData, add !empty checks for serialization, change algorithm from md5 to sha256, send deviceFingerprint for Ratepay

Api/Data/NotificationInterface.php

@@ -255,7 +255,7 @@ interface NotificationInterface
      * @param string $additionalData
      * @return $this
      */
-    public function setAddtionalData($additionalData);
+    public function setAdditionalData($additionalData);
 
     /**
      * Gets the Done for the notification.

Controller/Process/Json.php

@@ -222,7 +222,7 @@ class Json extends \Magento\Framework\App\Action\Action
                     $notification->setLive($notificationMode);
 
                     if (isset($response['additionalData'])) {
-                        $notification->setAddtionalData($this->serializer->serialize($response['additionalData']));
+                        $notification->setAdditionalData($this->serializer->serialize($response['additionalData']));
                     }
                     if (isset($response['done'])) {
                         $notification->setDone($response['done']);

Gateway/Request/CheckoutDataBuilder.php

@@ -140,6 +140,13 @@ class CheckoutDataBuilder implements BuilderInterface
 			$request = array_merge($request, $openInvoiceFields);
 		}
 
+        // Ratepay specific Fingerprint
+        if ($payment->getAdditionalInformation("df_value") && $this->adyenHelper->isPaymentMethodRatepayMethod(
+                $payment->getAdditionalInformation(AdyenHppDataAssignObserver::BRAND_CODE)
+            )) {
+            $request['deviceFingerprint'] = $payment->getAdditionalInformation("df_value");
+        }
+
         //Boleto data
         if ($payment->getAdditionalInformation("social_security_number")) {
             $request['socialSecurityNumber'] = $payment->getAdditionalInformation("social_security_number");

Helper/Data.php

@@ -1010,6 +1010,19 @@ class Data extends AbstractHelper
         return false;
     }
 
+    /**
+     * @param $paymentMethod
+     * @return bool
+     */
+    public function isPaymentMethodRatepayMethod($paymentMethod)
+    {
+        if (strpos($paymentMethod, 'ratepay') !== false) {
+            return true;
+        }
+
+        return false;
+    }
+
 	/**
 	 * @param $paymentMethod
 	 * @return bool

Model/Config/Backend/InstallmentsPosCloud.php

@@ -106,11 +106,12 @@ class InstallmentsPosCloud extends \Magento\Framework\App\Config\Value
     protected function _afterLoad()
     {
         $value = $this->getValue();
-        $value = $this->serializer->unserialize($value);
-
-        if (is_array($value)) {
-            $value = $this->encodeArrayFieldValue($value);
-            $this->setValue($value);
+        if(!empty($value)) {
+            $value = $this->serializer->unserialize($value);
+            if (is_array($value)) {
+                $value = $this->encodeArrayFieldValue($value);
+                $this->setValue($value);
+            }
         }
         return $this;
     }

Model/Cron.php

@@ -219,6 +219,11 @@ class Cron
      */
     private $transactionBuilder;
 
+    /**
+     * @var \Magento\Framework\Serialize\SerializerInterface
+     */
+    private $serializer;
+
     /**
      * Cron constructor.
      *
@@ -263,7 +268,8 @@ class Cron
         SearchCriteriaBuilder $searchCriteriaBuilder,
         OrderRepository $orderRepository,
         \Adyen\Payment\Model\ResourceModel\Billing\Agreement $agreementResourceModel,
-        \Magento\Sales\Model\Order\Payment\Transaction\Builder $transactionBuilder
+        \Magento\Sales\Model\Order\Payment\Transaction\Builder $transactionBuilder,
+        \Magento\Framework\Serialize\SerializerInterface $serializer
     ) {
         $this->_scopeConfig = $scopeConfig;
         $this->_adyenLogger = $adyenLogger;
@@ -285,6 +291,7 @@ class Cron
         $this->orderRepository = $orderRepository;
         $this->agreementResourceModel = $agreementResourceModel;
         $this->transactionBuilder = $transactionBuilder;
+        $this->serializer = $serializer;
     }
 
     /**
@@ -501,8 +508,7 @@ class Cron
         $this->_reason = $notification->getPaymentMethod();
         $this->_value = $notification->getAmountValue();
 
-
-        $additionalData = unserialize($notification->getAdditionalData());
+        $additionalData = !empty($notification->getAdditionalData()) ? $this->serializer->unserialize($notification->getAdditionalData()) : "";
 
         // boleto data
         if ($this->_paymentMethodCode() == "adyen_boleto") {
@@ -672,7 +678,8 @@ class Cron
     {
         $this->_adyenLogger->addAdyenNotificationCronjob('Updating the Adyen attributes of the order');
 
-        $additionalData = unserialize($notification->getAdditionalData());
+        $additionalData = !empty($notification->getAdditionalData()) ? $this->serializer->unserialize($notification->getAdditionalData()) : "";
+
         $_paymentCode = $this->_paymentMethodCode();
 
         if ($this->_eventCode == Notification::AUTHORISATION

Model/Notification.php

@@ -333,7 +333,7 @@ class Notification extends \Magento\Framework\Model\AbstractModel implements Not
      * @param string $additionalData
      * @return $this
      */
-    public function setAddtionalData($additionalData)
+    public function setAdditionalData($additionalData)
     {
         return $this->setData(self::ADDITIONAL_DATA, $additionalData);
     }

Model/Ui/AdyenHppConfigProvider.php

@@ -145,7 +145,7 @@ class AdyenHppConfigProvider implements ConfigProviderInterface
 
         $config['payment'] ['adyenHpp']['ratePayId'] = $this->adyenHelper->getRatePayId();
         // TODO: change the algorithm
-        $config['payment'] ['adyenHpp']['deviceIdentToken'] = md5($this->session->getQuoteId() . date('c'));
+        $config['payment'] ['adyenHpp']['deviceIdentToken'] = hash("sha256",$this->session->getQuoteId() . date('c'));
         $config['payment'] ['adyenHpp']['nordicCountries'] = ['SE', 'NO', 'DK', 'FI'];
 
         return $config;

etc/di.xml

@@ -980,6 +980,22 @@
             <argument name="serializer" xsi:type="object">Magento\Framework\Serialize\Serializer\Serialize</argument>
         </arguments>
     </type>
+    <type name="Adyen\Payment\Model\Ui\AdyenCcConfigProvider">
+        <arguments>
+            <argument name="serializer" xsi:type="object">Magento\Framework\Serialize\Serializer\Serialize</argument>
+        </arguments>
+    </type>
+    <type name="Adyen\Payment\Model\Cron">
+        <arguments>
+            <argument name="serializer" xsi:type="object">Magento\Framework\Serialize\Serializer\Serialize</argument>
+        </arguments>
+    </type>
+    <type name="Adyen\Payment\Controller\Process\Json">
+        <arguments>
+            <argument name="serializer" xsi:type="object">Magento\Framework\Serialize\Serializer\Serialize</argument>
+        </arguments>
+    </type>
+
     <preference for="Adyen\Payment\Api\GuestAdyenPaymentMethodManagementInterface"
                 type="Adyen\Payment\Model\GuestAdyenPaymentMethodManagement"/>
     <preference for="Adyen\Payment\Api\AdyenPaymentMethodManagementInterface"