Refactor, typos (#556)

* Refactor, typos
* remove duplicate case "Received"

.github/ISSUE_TEMPLATE.md

@@ -2,6 +2,6 @@
 **Plugin version**: x.y.z
 **Description**
 <!--
-- please provide description of the issue. In case of bug report, please provide the necessary steps to reproduce.
+- Please provide a description of the issue. In case of bug report, please provide the necessary steps to reproduce.
 - For merchant specific requests, please use https://support.adyen.com
 -->
\ No newline at end of file

Api/Data/NotificationInterface.php

@@ -25,10 +25,10 @@ namespace Adyen\Payment\Api\Data;
 
 interface NotificationInterface
 {
-
-    /**#@+
+    /**
      * Constants for keys of data array. Identical to the name of the getter in snake case.
      */
+
     /*
      * Entity ID.
      */
@@ -66,7 +66,7 @@ interface NotificationInterface
      */
     const AMOUNT_CURRENCY = 'amount_currency';
     /*
-    * reason
+     * Reason
      */
     const REASON = 'reason';
     /*
@@ -74,7 +74,7 @@ interface NotificationInterface
      */
     const LIVE = 'live';
     /*
-     * Live
+     * Done
      */
     const DONE = 'done';
     /*
@@ -109,7 +109,7 @@ interface NotificationInterface
     /**
      * Gets the Pspreference for the notification.
      *
-     * @return int|null Pspreference.
+     * @return string|null Pspreference.
      */
     public function getPspreference();
 
@@ -133,14 +133,14 @@ interface NotificationInterface
     /**
      * Gets the OriginalReference for the notification.
      *
-     * @return int|null OriginalReference.
+     * @return string|null OriginalReference.
      */
     public function getOriginalReference();
 
     /**
      * Gets the Merchantreference for the notification.
      *
-     * @return int|null MerchantReference.
+     * @return string|null MerchantReference.
      */
     public function getMerchantReference();
 
@@ -155,7 +155,7 @@ interface NotificationInterface
     /**
      * Gets the Eventcode for the notification.
      *
-     * @return int|null Eventcode.
+     * @return string|null Eventcode.
      */
     public function getEventCode();
 
@@ -172,7 +172,7 @@ interface NotificationInterface
      *
      * @return int|null Success.
      */
-    public function getSucess();
+    public function getSuccess();
 
     /**
      * Sets Success.
@@ -185,7 +185,7 @@ interface NotificationInterface
     /**
      * Gets the Paymentmethod for the notification.
      *
-     * @return int|null PaymentMethod.
+     * @return string|null PaymentMethod.
      */
     public function getPaymentMethod();
 
@@ -213,11 +213,11 @@ interface NotificationInterface
     public function setAmountValue($amountValue);
 
     /**
-     * Gets the AmountValue for the notification.
+     * Gets the AmountCurrency for the notification.
      *
-     * @return int|null AmountValue.
+     * @return string|null AmountCurrency.
      */
-    public function getAmountCurency();
+    public function getAmountCurrency();
 
     /**
      * Sets AmountCurrency.

Api/Data/OrderPaymentInterface.php

@@ -25,10 +25,10 @@ namespace Adyen\Payment\Api\Data;
 
 interface OrderPaymentInterface
 {
-
-    /**#@+
+    /**
      * Constants for keys of data array. Identical to the name of the getter in snake case.
      */
+
     /*
      * Entity ID.
      */

Block/Adminhtml/System/Config/Field/Installments.php

@@ -112,11 +112,11 @@ class Installments extends \Magento\Config\Block\System\Config\Form\Field\FieldA
      */
     protected function _prepareArrayRow(\Magento\Framework\DataObject $row)
     {
-        $installlments = $row->getInstallments();
+        $installments = $row->getInstallments();
 
         $options = [];
-        if ($installlments) {
-            $options['option_' . $this->getNumberOfInstallmentsRenderer()->calcOptionHash($installlments)]
+        if ($installments) {
+            $options['option_' . $this->getNumberOfInstallmentsRenderer()->calcOptionHash($installments)]
                 = 'selected="selected"';
 
             $ccTypes = $row->getCcTypes();

Block/Adminhtml/System/Config/Field/InstallmentsPosCloud.php

@@ -82,11 +82,11 @@ class InstallmentsPosCloud extends \Magento\Config\Block\System\Config\Form\Fiel
      */
     protected function _prepareArrayRow(\Magento\Framework\DataObject $row)
     {
-        $installlments = $row->getInstallments();
+        $installments = $row->getInstallments();
 
         $options = [];
-        if ($installlments) {
-            $options['option_' . $this->getNumberOfInstallmentsRenderer()->calcOptionHash($installlments)]
+        if ($installments) {
+            $options['option_' . $this->getNumberOfInstallmentsRenderer()->calcOptionHash($installments)]
                 = 'selected="selected"';
         }
         $row->setData('option_extra_attrs', $options);

Block/Form/Oneclick.php

@@ -36,7 +36,7 @@ class Oneclick extends \Adyen\Payment\Block\Form\Cc
     protected $_sessionQuote;
 
     /**
-     * Cc constructor.
+     * Oneclick constructor.
      *
      * @param \Magento\Framework\View\Element\Template\Context $context
      * @param \Magento\Payment\Model\Config $paymentConfig

Block/Info/Cc.php

@@ -32,9 +32,10 @@ class Cc extends AbstractInfo
     protected $_template = 'Adyen_Payment::info/adyen_cc.phtml';
 
     /**
-     * Return credit cart type
+     * Return credit card type
      *
      * @return string
+     * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function getCcTypeName()
     {

Block/Info/Hpp.php

@@ -49,7 +49,7 @@ class Hpp extends AbstractInfo
     }
 
     /**
-     * Get all multibanco related data
+     * Get all Multibanco related data
      *
      * @return array
      * @throws \Magento\Framework\Exception\LocalizedException

Controller/Process/Result.php

@@ -301,7 +301,7 @@ class Result extends \Magento\Framework\App\Action\Action
     }
     
     /**
-     * Authenticate using sha1 Merchant signature
+     * Authenticate using sha256 Merchant signature
      *
      * @param $response
      * @return bool

Gateway/Validator/CheckoutResponseValidator.php

@@ -94,9 +94,6 @@ class CheckoutResponseValidator extends AbstractValidator
                         $payment->setCcType($ccType);
                     }
 
-                    $payment->setAdditionalInformation('pspReference', $response['pspReference']);
-                    break;
-                case "Received":
                     $payment->setAdditionalInformation('pspReference', $response['pspReference']);
                     break;
                 case "PresentToShopper":

Model/Notification.php

@@ -197,7 +197,7 @@ class Notification extends \Magento\Framework\Model\AbstractModel implements Not
      *
      * @return int|null Success.
      */
-    public function getSucess()
+    public function getSuccess()
     {
         return $this->getData(self::SUCCESS);
     }
@@ -259,9 +259,9 @@ class Notification extends \Magento\Framework\Model\AbstractModel implements Not
     /**
      * Gets the AmountValue for the notification.
      *
-     * @return int|null AmountValue.
+     * @return string|null AmountValue.
      */
-    public function getAmountCurency()
+    public function getAmountCurrency()
     {
         return $this->getData(self::AMOUNT_CURRENCY);
     }
@@ -280,7 +280,7 @@ class Notification extends \Magento\Framework\Model\AbstractModel implements Not
     /**
      * Gets the Reason for the notification.
      *
-     * @return int|null Reason.
+     * @return string|null Reason.
      */
     public function getReason()
     {