optimize checks and use array instead of json

99f4ac9b · Rik ter Beek · Aleffio · 98f8bc09 · 99f4ac9b
Commit 99f4ac9b authored Sep 03, 2018 by Rik ter Beek Committed by Aleffio Nov 09, 2018
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 8 deletions

Model/AdyenInitiateTerminalApi.php Model/AdyenInitiateTerminalApi.php +7 -8

No files found.
--- a/Model/AdyenInitiateTerminalApi.php
+++ b/Model/AdyenInitiateTerminalApi.php
@@ -153,14 +153,13 @@ class AdyenInitiateTerminalApi implements AdyenInitiateTerminalApiInterface
            $shopperEmail = $quote->getCustomerEmail();
            $recurringContract = $this->_adyenHelper->getAdyenPosCloudConfigData('recurring_type');
-            if (!empty($recurringContract)) {
+            if (!empty($recurringContract) && !empty($shopperEmail) && !empty($customerId)) {
-                $jsonValue = '{
+                $recurringDetails = [
-                "shopperEmail": "' . $shopperEmail . '",
+                    ['shopperEmail'] => $shopperEmail,
-                "shopperReference": "' . $customerId . '",
+                    ['shopperReference'] => $customerId,
-                "recurringContract": "' . $recurringContract . '"
+                    ['recurringContract'] => $recurringContract
-             }';
+                ];
+                $request['SaleToPOIRequest']['PaymentRequest']['SaleData']['SaleToAcquirerData'] = base64_encode(json_encode($recurringDetails));
-                $request['SaleToPOIRequest']['PaymentRequest']['SaleData']['SaleToAcquirerData'] = base64_encode($jsonValue);
            }
        }