Store resultCode in variable (#849)

To prevent to access the array for the same information multiple times.

Store resultCode in variable (#849)
To prevent to access the array for the same information multiple times.
6fadad65 · choetzendorfer · GitHub · 329eb7a3 · 6fadad65
Commit 6fadad65 authored Oct 14, 2020 by choetzendorfer Committed by GitHub Oct 14, 2020
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 6 deletions

Gateway/Validator/CheckoutResponseValidator.php Gateway/Validator/CheckoutResponseValidator.php +7 -6

No files found.
--- a/Gateway/Validator/CheckoutResponseValidator.php
+++ b/Gateway/Validator/CheckoutResponseValidator.php
@@ -66,12 +66,13 @@ class CheckoutResponseValidator extends AbstractValidator
        $payment->setAdditionalInformation('3dActive', false);
        $isValid = true;
        $errorMessages = [];
+        $resultCode = $response['resultCode'];
        // validate result
-        if (!empty($response['resultCode'])) {
-            $payment->setAdditionalInformation('resultCode', $response['resultCode']);
-            switch ($response['resultCode']) {
+        if (!empty($resultCode)) {
+            $payment->setAdditionalInformation('resultCode', $resultCode);
+            switch ($resultCode) {
                case "IdentifyShopper":
-                    $payment->setAdditionalInformation('threeDSType', $response['resultCode']);
+                    $payment->setAdditionalInformation('threeDSType', $resultCode);
                    $payment->setAdditionalInformation(
                        'threeDS2Token',
                        $response['authentication']['threeds2.fingerprintToken']
@@ -79,7 +80,7 @@ class CheckoutResponseValidator extends AbstractValidator
                    $payment->setAdditionalInformation('adyenPaymentData', $response['paymentData']);
                    break;
                case "ChallengeShopper":
-                    $payment->setAdditionalInformation('threeDSType', $response['resultCode']);
+                    $payment->setAdditionalInformation('threeDSType', $resultCode);
                    $payment->setAdditionalInformation(
                        'threeDS2Token',
                        $response['authentication']['threeds2.challengeToken']
@@ -130,7 +131,7 @@ class CheckoutResponseValidator extends AbstractValidator
                    }
                    break;
                case "RedirectShopper":
-                    $payment->setAdditionalInformation('threeDSType', $response['resultCode']);
+                    $payment->setAdditionalInformation('threeDSType', $resultCode);

                    $redirectUrl = null;
                    $paymentData = null;