Commit 6fadad65 authored by choetzendorfer's avatar choetzendorfer Committed by GitHub

Store resultCode in variable (#849)

To prevent to access the array for the same information multiple times.
parent 329eb7a3
...@@ -66,12 +66,13 @@ class CheckoutResponseValidator extends AbstractValidator ...@@ -66,12 +66,13 @@ class CheckoutResponseValidator extends AbstractValidator
$payment->setAdditionalInformation('3dActive', false); $payment->setAdditionalInformation('3dActive', false);
$isValid = true; $isValid = true;
$errorMessages = []; $errorMessages = [];
$resultCode = $response['resultCode'];
// validate result // validate result
if (!empty($response['resultCode'])) { if (!empty($resultCode)) {
$payment->setAdditionalInformation('resultCode', $response['resultCode']); $payment->setAdditionalInformation('resultCode', $resultCode);
switch ($response['resultCode']) { switch ($resultCode) {
case "IdentifyShopper": case "IdentifyShopper":
$payment->setAdditionalInformation('threeDSType', $response['resultCode']); $payment->setAdditionalInformation('threeDSType', $resultCode);
$payment->setAdditionalInformation( $payment->setAdditionalInformation(
'threeDS2Token', 'threeDS2Token',
$response['authentication']['threeds2.fingerprintToken'] $response['authentication']['threeds2.fingerprintToken']
...@@ -79,7 +80,7 @@ class CheckoutResponseValidator extends AbstractValidator ...@@ -79,7 +80,7 @@ class CheckoutResponseValidator extends AbstractValidator
$payment->setAdditionalInformation('adyenPaymentData', $response['paymentData']); $payment->setAdditionalInformation('adyenPaymentData', $response['paymentData']);
break; break;
case "ChallengeShopper": case "ChallengeShopper":
$payment->setAdditionalInformation('threeDSType', $response['resultCode']); $payment->setAdditionalInformation('threeDSType', $resultCode);
$payment->setAdditionalInformation( $payment->setAdditionalInformation(
'threeDS2Token', 'threeDS2Token',
$response['authentication']['threeds2.challengeToken'] $response['authentication']['threeds2.challengeToken']
...@@ -130,7 +131,7 @@ class CheckoutResponseValidator extends AbstractValidator ...@@ -130,7 +131,7 @@ class CheckoutResponseValidator extends AbstractValidator
} }
break; break;
case "RedirectShopper": case "RedirectShopper":
$payment->setAdditionalInformation('threeDSType', $response['resultCode']); $payment->setAdditionalInformation('threeDSType', $resultCode);
$redirectUrl = null; $redirectUrl = null;
$paymentData = null; $paymentData = null;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment